Messed up layout

Join our forum today, it's free!

Register now and get access to all php class downloads!
Members are able to post new topics and comments.
Create a member profile and share your social profile links.
The abbility to follow your favorite forum topics.

PHP Script Forums » General Web Development Forum

(12 posts)

Tags:

Started 10 months ago by fl00r
Latest reply from Olaf

Great offers for webmaster, blogger and web developer!

12 Next »

fl00r
Member

Dear all,

In my BBpress site I have a 'Terms of Service' plug in for the users to accept during registration.
Now, when people forget to accept the terms they get an error page. Unfortunately the layout of this error page is messed up.
You see what I mean when you go to http://204.12.19.206/register.php register and leave the accept check box unchecked.

In my (very) limited knowledge of PHP I think the culprit is in the below code:

function terms_of_service_check() {	// examine the answer
	if ($_POST && (!isset($_POST['terms_of_service']) || $_POST['terms_of_service']!="agree")) {
		bb_get_header();	?>
		<br clear='both' /><h2 id='register' style='margin-left:2em;'>
		<div class="indent">
		<h2 id="register"><?php _e('?'); ?></h2>
		<p align='center'><font size='-1'><?php _e("Oei, zoals je ziet is er iets fout gegaan. Je bent waarschijnlijk vergeten akkoord te gaan met de gebruiksvoorwaarden"); ?>
		<br /><a href='register.php'><?php _e("Ga terug"); ?>.</a></font>
		<?php bb_get_footer();
		exit;
	}
}

Please let me know if you need the whole code.

Thanks,

Ben

Posted 10 months ago #

Olaf
PHP Coder

The human test script on my registration page has a similar template call:

 
		if ($human_test_post !=$compare || !empty($_POST['ht_confirm'])) {				
 
			bb_send_headers();
 
			bb_get_header();
 
			echo "<br clear='both' /><h2 id='register' style='margin-left:2em;'>".__("Error")."</h2><p align='center'><font size='+1'>".
 
			__("Humans only please").". ".__("If you are not a bot").", 
 
			".__("please <a href="history.go(-1)">go back</a> and try again").			
 
			".</font></p>";
 
			bb_get_footer();
 
			exit;

you see the difference? bb_send_headers();

To get the working your header and footer have to work for 100%, will say is the header has opened a container, this container need to get closed inside the footer!

Posted 10 months ago #

fl00r
Member

Please excuse my ignorance but are you saying that I need to close a container in footer.php? And if so, where?

As you can tell by now, I am a complete moron when it comes to PHP but I am willing to learn.

Thanks

Posted 10 months ago #
Olaf
PHP Coder
The container thing is not related to PHP it's just how a template work.
for example your header looks like:
```
<html>
<body>
  <wrapper>
    <header>
      <h1>Hello World!</h1>
    </header>
    <content>
```
your footer need end the page like:
```
</content>
    <footer>&copy; 2009</footer>
  </wrapper>
</body>
</html>
```
Don't look for my name conventions
Posted 10 months ago #
fl00r
Member
Sorry for nagging but my header and footer do work 100% site wide.
It's just this particular error page that is not showing right.

My footer begins with:
```
</div>
	
```
Posted 10 months ago #
Olaf
PHP Coder

do you added this row to your function?

bb_send_headers();

Posted 10 months ago #

fl00r
Member

Here's what I have now:

function terms_of_service_check() {	// examine the answer
	if ($_POST && (!isset($_POST['terms_of_service']) || $_POST['terms_of_service']!="agree")) {
		bb_send_headers();
		bb_get_header();	?>
		<br clear='both' /><h2 id='register' style='margin-left:2em;'>
		<div class="indent">
		<h2 id="register"><?php _e('?'); ?></h2>
		<p align='center'><font size='-1'><?php _e("Oei, zoals je ziet is er iets fout gegaan. Je bent waarschijnlijk vergeten akkoord te gaan met de gebruiksvoorwaarden"); ?>
		<br /><a href='register.php'><?php _e("Ga terug"); ?>.</a></font>
		<?php bb_get_footer();
		exit;
	}
}

But the result is a blank error-page

Posted 10 months ago #

Olaf
PHP Coder

Okay it seems that the function/template doesn't support this. Remove the header function

I see you have this container <div class="indent"> open and not closed.

check also if you "clear" floated containers in your footer.

Posted 10 months ago #
fl00r
Member

I am almost there: when I delete <div class="indent"> the layout of the page is fine. The only thing that goes wrong is that the fonts size in the right sidebar is to big. I think that this is due to the fact that <div class="indent"> isn't closed properly. Any idea where to close the <div class="indent">?

Posted 10 months ago #
Olaf
PHP Coder

At the moment the "indent" container has no function.
You need to compare the HTML from the "regular" register page with the html from the error message.

yeah I know at the beginning it's hard to style templates, but with every finished site you became better

Posted 10 months ago #

RSS feed for this topic

12 Next »

Reply »

You must log in to post.